http2: RFC8441 extended connect protocol #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support the Extended Connect Protocol defined by RFC 8441. - Add a new pseudoheader :protocol - New HTTP2 Server option "EnableConnectProtocol" to enable the HTTP2 ENABLE_CONNECT_PROTOCOL setting. - HTTP Request field "Proto", that was ignored from Clients, now is used for setting the field ":protocol" on Connect requests Change-Id: I1e4bf6a45bd667fa5e5388678bee0feac64641c1
aojea
commented
Jan 9, 2022
| f(":path", path) | ||
| f(":scheme", req.URL.Scheme) | ||
| if isExtendedConnect { | ||
| f(":protocol", req.Proto) |
There was a problem hiding this comment.
I didn't find a good way to plumb down the protocol field, maybe adding a new semantic to the current protocol field? it seems is unused right now for clients
// The protocol version for incoming server requests.
//
// For client requests, these fields are ignored. The HTTP
// client code always uses either HTTP/1.1 or HTTP/2.
// See the docs on Transport for details.
Proto string // "HTTP/1.0"
|
@aojea did you ever get any feedback on this? I am working in the same space and would love to move this forward. |
no feedback sorry, I wrote my comments on the open issue with my observations, but I don't really know how golang community works for adding new features |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the Extended Connect Protocol defined by RFC 8441.
the HTTP2 ENABLE_CONNECT_PROTOCOL setting.
is used for setting the field ":protocol" on Connect requests
Change-Id: I1e4bf6a45bd667fa5e5388678bee0feac64641c1